foreach loop from multiple arrays c#

Question

This should be a simple question. All I want to know is if there is a better way of coding this. I want to do a foreach loop for every array, without having to redeclare the foreach loop. Is there a way c# projects this? I was thinking of putting this in a Collection...?

Please, critique my code.

        foreach (TextBox tb in vert)
        {
            if (tb.Text == box.Text)                
                conflicts.Add(tb);                
        }
        foreach (TextBox tb in hort)
        {
            if (tb.Text == box.Text)                
                conflicts.Add(tb);                
        }
        foreach (TextBox tb in cube)
        {
            if (tb.Text == box.Text)
                conflicts.Add(tb);                
        }

Yes, in short, each array is a textbox[] of cube, hort, and vert Textboxes of a sudoku prog. So for structural purposes, I'd like to have each array independent of others. — Mike
– Mike, Commented Jun 1, 2010 at 14:21

SLaks · Accepted Answer · 2010-06-01 14:12:46Z

13

You can use LINQ:

conflicts.AddRange(
    vert.Concat(hort).Concat(cube)
        .Where(tb => tb.Text == box.Text)
);

I'm assuming that conflicts is a List<TextBox>, which has an AddRange method. If it isn't, you'll need to call Add in a (single) loop.
If you're creating conflicts, (or if it starts empty), you can call .ToList() instead.

answered Jun 1, 2010 at 14:12

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Mike Over a year ago

I changed my conflicts var from TextBox[] to List<TextBox>. works great! Thanks to all the responses!

SLaks Over a year ago

You can also write conflicts = (...).ToArray().

Mike Over a year ago

because there is once instance of the same textbox in each array, I simply add the where clause (... && tb.Name != box.Name) –

SLaks Over a year ago

@Mike: ` && tb != box. You don't need to compare the Name` strings.

ljs · Accepted Answer · 2010-06-01 14:14:59Z

3

Another .net 3.5 approach:-

conflicts.AddRange(from textBox in vert.Concat(hort).Concat(cube)
                   where textBox.Text == box.Text
                   select textBox);

answered Jun 1, 2010 at 14:14

ljs

37.9k36 gold badges110 silver badges124 bronze badges

Comments

Randolpho · Accepted Answer · 2010-06-01 14:18:04Z

1

If you can't use LINQ for whatever reason (and I highly suggest you do) you could make your array searching a single method. For example:

public void FindConflicts(IEnumerable<TextBox> tbList, IList<TextBox> conflicts, string test)
{
   foreach(TextBox tb in tbList)
   {
      if(tb.Text == test)
      {
          conflicts.Add(tb);
      }
   }
}

And then call it like so:

FindConflicts(vert, conflicts, box.Text);
FindConflicts(hort, conflicts, box.Text);
FindConflicts(cube, conflicts, box.Text);

answered Jun 1, 2010 at 14:18

Randolpho

56.5k18 gold badges153 silver badges182 bronze badges

Comments

JeppeSN · Accepted Answer · 2010-06-01 14:44:56Z

1

There are of course many ways to write this, but you could also do

  foreach (var direction in new[] { vert, hort, cube })
    foreach (TextBox tb in direction)
      if (tb.Text == box.Text)
        conflicts.Add(tb);

answered Jun 1, 2010 at 14:44

JeppeSN

211 bronze badge

Comments

Justin Niessner · Accepted Answer · 2010-06-01 14:13:01Z

0

var unionResult = vert.Concat(hort).Concat(cube)

foreach(TextBox tb in unionResult)
    if(tb.Text == box.Text)
        conflicts.Add(tb);

answered Jun 1, 2010 at 14:13

Justin Niessner

246k40 gold badges416 silver badges546 bronze badges

Comments

48klocs · Accepted Answer · 2010-06-01 14:19:48Z

0

You should be able to use Enumerable.Concat to glue them together if you're using .Net 3.5 or higher.

foreach (TextBox tb in vert.Concat(hort).Concat(cube))

edited Jun 1, 2010 at 14:19

answered Jun 1, 2010 at 14:14

48klocs

6,1233 gold badges29 silver badges35 bronze badges

3 Comments

SLaks Over a year ago

Union will remove duplicates

Mike Over a year ago

I do not want to remove dups, as each array is a collection of 9 textboxes. If Union eliminates dups, is there a natural join function?

48klocs Over a year ago

@Slaks - thanks. I knew that (and included a link to the documentation on Enumerable.Concat), but my fingers didn't cooperate with my brain when I typed out the code example. I edited it to use the Concat method instead of Union.

Daniel Bern · Accepted Answer · 2010-06-01 14:45:44Z

-1

If you try to create Sudoku game(mentioned in comments) first read about Permutation group and Combinatorics. This will help you to choose more efficient Application Model w/o using foreach on text boxes. Using lazy computation resolve the problem with object reduction but not improve your logics man.

answered Jun 1, 2010 at 14:45

Daniel Bern

1372 bronze badges

1 Comment

Mike Over a year ago

I appreciate the reference, but this is entirely for learning purposes.

Collectives™ on Stack Overflow

foreach loop from multiple arrays c#

7 Answers 7

4 Comments

Comments

Comments

Comments

Comments

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

4 Comments

Comments

Comments

Comments

Comments

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related