Send variable from function javascript

Question

I have a code

 socket.on('user joined',function(data){
       var ume = data.username;
        $('#userlist').append("<li id='"+ume+"'><a href='#' onclick='prePrivate("+ume+"); return false;'>"+ume+"</a></li>");
        console.log(ume);
 });

and prePrivate method

  function prePrivate(userprivate){
        privateuser = userprivate;
        console.log(privateuser);
  }

When i click li element, console print

<li id="sample_data">

but not print sample_data. I do not understand, how to get variable. Sorry my english not good

i want get value of variable "ume" but code print <li id="sample_data"> — bulubuloa
– bulubuloa, Commented Mar 31, 2015 at 2:56
example: ume = "hoang" , i want console print hoang, but console print <li id="hoang"> — bulubuloa
– bulubuloa, Commented Mar 31, 2015 at 2:59
you need to add quotes around ume in the string where you call prePrivate onclick: ...onclick='prePrivate(\""+ume+"\"); ... — sebnukem
– sebnukem, Commented Mar 31, 2015 at 3:31

Community · Accepted Answer · 2017-05-23 12:22:14Z

2

You need to add quotes around ume in the prePrivate call in the string that you are building: ...onclick='prePrivate(\""+ume+"\");...

Without them you are calling prePrivate(sample_data) and sample_data happens to be the DOM li element you just id'ed with that same name instead of a string. Why? See Do DOM tree elements with ids become global variables?

edited May 23, 2017 at 12:22

CommunityBot

11 silver badge

answered Mar 31, 2015 at 3:38

sebnukem

8,3536 gold badges40 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Send variable from function javascript

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest