JQuery - get a variable from the URL to set a CSS value

Question

I wrote this code in order to set the text color of an active menu item:

$(document).ready(function () {

var url = window.location.href;
var pieces = url.split("?whatPage=");

$('#pieces[1]').css('color', 'red');
});

If I alert pieces[1] I get the value of the ID of the relevant menu item, but the menu item's color is unaffected. What is most likely to be going wrong?

you use your variable as your selector-string, you have to concatenate them: $('#' + pieces[1]) — empiric
– empiric, Commented Mar 12, 2015 at 10:23
thanks, I understand. Changed it, but it doesn't work yet .. — Sam
– Sam, Commented Mar 12, 2015 at 10:37

K K · Accepted Answer · 2015-03-12 10:22:41Z

3

Instead of $('#pieces[1]').css('color', 'red');

try :

$('#'+pieces[1]).css('color', 'red');

answered Mar 12, 2015 at 10:22

K K

18.2k4 gold badges33 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Sam Over a year ago

Hmm tried, but that wasn't it, or at least there is something else incorrect apparently .. Is there perhaps something more fundamentally wrong with my idea, or should it work?

K K Over a year ago

Maybe you don't have the element with that id on the page.

Sam Over a year ago

actually I do .. <a id="<?php echo $cols[1];?>menu item</a> I checked page source and it is similar to an alert of pieces[1]

K K Over a year ago

Can you share the HTML and CSS(if any)

Sam Over a year ago

so there is no CSS, just the custom one I try to apply to the a-tag.

|

Collectives™ on Stack Overflow

JQuery - get a variable from the URL to set a CSS value

1 Answer 1

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related