Javascript Pushing Objects to Array

Question

I'm unable to push objects to an array and i can't figure out why. At the moment, the result (records) repeats the last instance of the each loop.

JSFiddle

HTML

<div data-provider="prv1"></div>
<div data-rating="rtn1"></div>
<div data-price="prc1"></div>

<div data-provider="prv2"></div>
<div data-rating="rtn2"></div>
<div data-price="prc2"></div>

<div data-provider="prv3"></div>
<div data-rating="rtn3"></div>
<div data-price="prc3"></div>

<div data-provider="prv4"></div>
<div data-rating="rtn4"></div>
<div data-price="prc4"></div>

Javascript (w/ jQuery)

(function(){

  var sort = $(".sort select");
  var provider = $("[data-provider]");
  var rating = $("[data-rating]");
  var price = $("[data-price]");

  var records = [];
  var record = {};

  $(provider).each(function(index, value){
    record.provider = $(provider).eq(index).data("provider"); 
    record.rating = $(rating).eq(index).data("rating");
    record.price = $(price).eq(index).data("price");
    records[index] = record;
  });


})();

hassassin · Accepted Answer · 2015-02-03 01:59:03Z

2

In your loop you set each index to be equal to record. Since the scope of record is the anonymous function, it will be the same object for each index.

What you want is for the scope to be the function provided to .each

Like this fiddle

$(provider).each(function(index, value){
    var record = {};
    ...
});

answered Feb 3, 2015 at 1:59

hassassin

5,0641 gold badge32 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Jack Over a year ago

This is the right answer, i will accept it. However, could you explain a little more? I expected the record object to be re-assigned for each loop iteration. Why can I access the outer scope for records, but not record?

Felix Kling Over a year ago

@Jack: "I expected the record object to be re-assigned for each loop iteration." Why did you expect that for record, but not records?

Felix Kling Over a year ago

@JackTuck: I'm confused. I thought you meant that in each iteration, record was a new object. However, that would imply that records must be a new array in each iteration as well. I.e. in each iteration, you would assign a single element to a new array. But, I'm quite certain that you expected that there is only a single results array and you are filling the array with multiple objects.

Jack Over a year ago

"Why did you expect that for record, but not records?". I did, but record was where I didn't see that behaviour. I don't understand why this answer works.

Jack Over a year ago

I understand why record would be equal to the result from the last loop iteration, but I don't get why the records array wasn't catching the object which resulted from the loops beforehand, as-being as the array was getting pushed to on each iteration.

|

Collectives™ on Stack Overflow

Javascript Pushing Objects to Array

HTML

Javascript (w/ jQuery)

1 Answer 1

10 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

HTML

Javascript (w/ jQuery)

1 Answer 1

10 Comments

Your Answer

Sign up or log in

Post as a guest

Related