Append variables to existing array

Question

Okay...this is what I have:

$('#more_rows').click(function(){
var allvars = [];
var threevar = $('#third_select option:selected').text();
allvars.push(threevar);
});

This gets the text of the currently selected option for a select box. What I thought it would do is push that text into the newly created allvars array. It pushes the text in the first time the click function happens and I get this:

["Example Text 1"]

However, when a new option is chosen from the select and the click function happens again, I get this:

["Example Text 2"]

What I want is:

["Example Text 1","Example Text 2"]

And to be able to add as many items as needed to this array.

What mistake am I making here and is there a better way to do this?

vjdhama · Accepted Answer · 2015-01-14 01:38:50Z

2

Just move the array initialization out of the function.

$(function() {
   var allvars = [];

    $('#more_rows').click(function(){
        var threevar = $('#third_select option:selected').text();
        allvars.push(threevar);
    });
});

edited Jan 14, 2015 at 1:38

answered Jan 14, 2015 at 0:57

vjdhama

5,1185 gold badges35 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

jonmrich Over a year ago

No idea how I missed that. Thanks.

Subash · Accepted Answer · 2015-01-14 00:58:33Z

1

You will need to create the array outside of the scope of the function.

Basically everytime you click on the select box, you are creating new empty variable and are pushing the value inside it.

var allvars = [];

$('#more_rows').click(function(){

var threevar = $('#third_select option:selected').text();
    allvars.push(threevar);
});

answered Jan 14, 2015 at 0:58

Subash

7,3068 gold badges47 silver badges73 bronze badges

Comments

Ja͢ck · Accepted Answer · 2015-01-14 01:09:42Z

1

Your allvars gets redeclared each time inside the click handler; considering scoping it outside, e.g. inside the DOM ready handler:

jQuery(function($) {
    var allvars = [];

    $('#more_rows').click(function() {
        var threevar = $('#third_select option:selected').text();
        allvars.push(threevar);
    });
});

edited Jan 14, 2015 at 1:09

answered Jan 14, 2015 at 0:58

Ja͢ck

174k39 gold badges269 silver badges316 bronze badges

Comments

sunnycr4 · Accepted Answer · 2015-01-14 01:21:11Z

0

Every Time when click event is dispatched you are creating new array.

answered Jan 14, 2015 at 1:21

sunnycr4

262 bronze badges

Collectives™ on Stack Overflow

Append variables to existing array

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest