JavaScript onclick event doesnt work with parameters

Question

So i have a button with this event attached:

apagar.onclick = cl.teste(this);

cl is an instance of another class , i think it doesnt matter to this case. The teste method is here:

Clinica.prototype.teste = function ()
{
    alert(this.doentes.length);
}

even when i have some parameters on the function, and i set them on the onclick event, the button just does nothing. But, when i set it like this: apagar.onclick = cl.teste; it works. I need the arguement because i need the 'this' statement to work properly for the object and not for the event.

apagar.addEventListener('click', cl.teste.bind(cl), false); — adeneo
– adeneo, Commented Jan 3, 2015 at 15:34

JLRishe · Accepted Answer · 2015-01-03 15:32:36Z

4

You can use bind in this situation:

apagar.onclick = cl.teste.bind(cl);

answered Jan 3, 2015 at 15:32

JLRishe

102k19 gold badges138 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

meskobalazs · Accepted Answer · 2015-01-03 15:33:33Z

3

Instead of writing:

apagar.onclick = cl.teste(this);

You can write:

apagar.onclick = function () {
    cl.teste(apagar);
};

The onclick event can be attached to a function not to a function-call. Here cl.teste is a function, while cl.tests(this) is a function call. With my workaround, it should work.

edited Jan 3, 2015 at 15:33

meskobalazs

16.1k2 gold badges44 silver badges63 bronze badges

answered Jan 3, 2015 at 15:29

Nicola Ferraro

4,2196 gold badges32 silver badges61 bronze badges

4 Comments

meskobalazs Over a year ago

Yes, onclick is an event handler, not a property!

Pedro Costa Over a year ago

yea i just did that before reading this post ! ty for help :) it worked !

JLRishe Over a year ago

It's not entirely clear from the question, but I think this.doentes.length is a property on cl. So you would use cl.teste(cl) here, not cl.teste(apagar).

Pedro Costa Over a year ago

i used: apagar.addEventListener('click', function () { cl.removerDoente(this);});

Collectives™ on Stack Overflow

JavaScript onclick event doesnt work with parameters

2 Answers 2

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related