AngularJS controller functions best practices

Question

If I want to refer to my angular controller function from a template, I should put the function in $scope, like this:

[template]
<button ng-click="doSomething()"></button>

[controller]
$scope.doSomething = function(){};

But what about other functions (and controller variables that I don't need to be watched), the ones that I will not reference in templates.

Should I put them all in '$scope' too? Isn't it bad for performance? Is there any gotchas in declaring such functions outside of $scope?

You should not put them in scope. Just define them inside controller like regular functions and variables. — Madhur Ahuja
– Madhur Ahuja, Commented Nov 16, 2014 at 13:54
@MadhurAhuja like this.myFunction=.. or var myFunction=...? — Anri
– Anri, Commented Nov 16, 2014 at 13:55
I prefer function myFunction() {... }. The problem with var myFunction=... is that it can be called only after where it is declared. — Madhur Ahuja
– Madhur Ahuja, Commented Nov 16, 2014 at 14:01
What @charlietfl means is this: codetunnel.io/angularjs-controller-as-or-scope - check it out ;) — Michael Rose
– Michael Rose, Commented Nov 16, 2014 at 14:05

plalx · Accepted Answer · 2014-11-16 14:25:57Z

5

You can simply define those as private functions within the controller's function.

Note that I also favor the function declaration syntax rather than assigning a function expression to a variable because it allows you to have all your functions declared at the bottom which reduces cognitive load when trying to see what's going on.

app.controller('MainCtrl', function ($scope) {
  $scope.exposedFn = exposedFn;

  function exposedFn() {
      fnNotExposed();
  }

  function fnNotExposed() {}

});

answered Nov 16, 2014 at 14:25

plalx

43.8k7 gold badges77 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

AngularJS controller functions best practices

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related