Change button image on click in wpf c#

Question

I am creating a tic tac toe game for windows 8.1 store using xaml and c# and was trying to change the X and O button on click. Initially, I have a blank image set in the xaml for the button and in the button_click event, I am trying to change the image source. Here is a snippet of my code:

private void Button_Click(object sender, RoutedEventArgs e)
    {
        Button btn = sender as Button;
        if (turn == 1)
        {
            BitmapImage bmp = new BitmapImage();
            Uri u = new Uri("ms-appx:/Images/O_logo.png", UriKind.RelativeOrAbsolute);
            bmp.UriSource = u;
            ImageBrush i = new ImageBrush();
            i.ImageSource = bmp;
            btn.Background = i;
        }
        else
        {
            BitmapImage bmp = new BitmapImage();
            Uri u = new Uri("ms-appx:/Images/X_logo.png", UriKind.RelativeOrAbsolute);
            bmp.UriSource = u;
            ImageBrush i = new ImageBrush();
            i.ImageSource = bmp;
            btn.Background = i;

        }
        btn.IsEnabled = false;
        //win(btn.Content.ToString());
        turn += 1;
        if (turn > 2)
            turn = 1;
    }

I have read a few articles online and some of them suggested that I set the build action of my image to Resource, however I do not have that as an option. I have PRIResource and Embedded Resource as an option. I have very limited knowledge of mvvm and triggers and hence would like to solve the problem using wpf itself and not in xaml.

I am using VS Studio Professional 2013

Why not use a ToggleButton with X & O for the IsChecked true/false states? Seems like extra work this way. — Chris W.
– Chris W., Commented Apr 23, 2014 at 2:35
if i use toggle button how can i determine which image to display as once a player can select X and another turn the player can select O. I think I would have to bind the data in this case right? Also initially i would need the button to display a blank image right hence that makes it 3 states. blank , X and O — justin3250
– justin3250, Commented Apr 23, 2014 at 3:00
Well the 3 state thing shouldn't pose much challenge. Then you could just throw their state down the tree based on which player is up. — Chris W.
– Chris W., Commented Apr 23, 2014 at 3:02
so this would require me to bind the data or use triggers? I am not really sure how to go about it . I would set isThreeState property to True and how would I set the value of each state in the xaml or .cs file ? — justin3250
– justin3250, Commented Apr 23, 2014 at 3:12
Ya you could bind the IsChecked state twoway and base the players click event on whether its player1 or player2 will put it in IsChecked=True or False or x:Null, but I may be over complicating it also lol, would have to stew on this one for a minute. — Chris W.
– Chris W., Commented Apr 23, 2014 at 3:31

Damir Arh · Accepted Answer · 2014-04-23 04:53:59Z

3

Background is not displayed when the button is disabled. You should rather have an Image as the button content:

private void Button_Click(object sender, RoutedEventArgs e)
{
    Button btn = sender as Button;
    if (turn == 1)
    {
        BitmapImage bmp = new BitmapImage();
        Uri u = new Uri("ms-appx:/Images/O_logo.png", UriKind.RelativeOrAbsolute);
        bmp.UriSource = u;
        // NOTE: change starts here
        Image i = new Image();
        i.Source = bmp;
        btn.Content = i;
    }
    else
    {
        BitmapImage bmp = new BitmapImage();
        Uri u = new Uri("ms-appx:/Images/X_logo.png", UriKind.RelativeOrAbsolute);
        bmp.UriSource = u;
        // NOTE: change starts here
        Image i = new Image();
        i.Source = bmp;
        btn.Content = i;

    }
    btn.IsEnabled = false;
    //win(btn.Content.ToString());
    turn += 1;
    if (turn > 2)
        turn = 1;
}

I would also strongly suggest you learn and start using XAML and binding instead of avoiding it. You're actually "fighting" against WPF the way you are using it and making it much harder for yourself. You might find it superior to Windows Forms if you use it as intended.

answered Apr 23, 2014 at 4:53

Damir Arh

17.9k2 gold badges49 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

justin3250 Over a year ago

Thank you very much. This works perfectly. Yes I shall start learning binding and XAML more

Shadow · Accepted Answer · 2014-04-23 03:59:38Z

1

I have done something very similar in WPF, not tic tac toe, but having multiple data grids, each with a different background occupying the exact same position, and enabling/disabling then with a button. I'd write some code down, but I don't know wpf off the top of my head like I do winforms, and they are very different (Main difference is wpf is crap in comparison).

But something like:

button1_click(object sender, EventArgs e)
{
    if (turn == 1)
    {
        gridX.Visibility = visible;
    }
    else
    {
        gridO.Visibility = visible;

    }
    button1.Visibility = hidden;
}

Then just put the images inside the grids, or labels, or w/e

answered Apr 23, 2014 at 3:59

Shadow

4,0265 gold badges23 silver badges43 bronze badges

2 Comments

justin3250 Over a year ago

Yes thank you for your suggestion. I was doing the same when I realized I will have to make many grids or buttons in my case and set their visibility to collapsed or visible. Seems like a lot of xaml code and hence thought of changing the image in the .cs file itself

Shadow Over a year ago

I see. WPF is complicated, in winforms it'd be as easy as going: button1.Image = Namespace.Properties.Resources.imageName;

Collectives™ on Stack Overflow

Change button image on click in wpf c#

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related