javascript adding a parameter on dynamically created button

Question

i created a button that will be created dynamically, so the html content of the button is written on javascript string. this is my code:

<tr>
    <td><input type='button' value='Apply Now' 
        onclick='pageRedirect('" + entity.ServiceID + "', '" + 
            entity.RecordID + "');'>
    </td>
</tr>

this code does not work, particularly on the part where i assigned the parameter. i also tried this code with escape sequence but still the same error.

<tr>
    <td>
        <input type='button' value='Apply Now' 
            onclick='pageRedirect(\'" + entity.ServiceID +"\', \'" + 
                entity.RecordID + "\');'>
    </td>
</tr>

I don't know what I'm missing. Some help please?

Your quoting is just wrong in onclick = 'pageRedirect('" + entity.ServiceID +"', '" + entity.RecordID + "');' Assuming pageRedirect and entity are global symbols, I'm not sure why you don't just use onclick='pageRedirect(entity.ServiceID,entity.RecordID);' — jfriend00
– jfriend00, Commented Mar 17, 2014 at 5:09
if i remove the single quotes on the assigning of parameters, the console returns this error: Uncaught SyntaxError: Unexpected token ILLEGAL — Dustine Tolete
– Dustine Tolete, Commented Mar 17, 2014 at 5:14
@DustineTolete you can get your error from the code highlighting itself on SO. — aelor
– aelor, Commented Mar 17, 2014 at 5:16

Menztrual · Accepted Answer · 2014-03-17 05:23:57Z

2

You're escaping/closing the wrong quotes. In your code snippet you're actually ending the onclick attribute. IE: onclick='pageRedirect(' ...everything after is now a new attribute

Try something like the following:

"<tr><td><input type = 'button' value = 'Apply Now' onclick = 'pageRedirect(\"" + entity.ServiceID +"\", \"" + entity.RecordID + "\");'></td></tr>"

edited Mar 17, 2014 at 5:23

answered Mar 17, 2014 at 5:14

Menztrual

41.7k12 gold badges59 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

jfriend00 Over a year ago

Why not just onclick='pageRedirect(entity.ServiceID, entity.RecordID);'?

Dustine Tolete Over a year ago

@jfriend00 even i don't know why. i tried it even before asking this question here.

jfriend00 Over a year ago

@DustineTolete - The simpler version works here: jsfiddle.net/jfriend00/EZ8HX so there must be something about your page that you aren't showing us.

Collectives™ on Stack Overflow

javascript adding a parameter on dynamically created button

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related