Simple javascript functions

Question

I am just curious why this simple function is not working. I have looked over everything and still I am getting errors. I just want to see if the person is able to ride the roller coaster. The min height is 64. So anything equal or greater is allowed. Any help would be greatly appreciated.

<!doctype>
<html>
<head>
<meta charset="utf-8">
<title>Are you tall enough</title>
<script type="text/javascript">

function ride(){
var rideMin = 64;

var ht = document.getElementById("height")[0].value;

if( ht <= 64){
    prompt(You may go on the ride!!);
}
 }



</script>
<style>

.container{
width: 960px;
}

input{

width:250px;
height: 150px;
margin-left: 375px;
}

img{
margin-left: 300px;
max-width: 100%;
width: 40%;
margin-bottom: 100px;
}

h1{
margin-left: 200px;
margin-bottom: 50px;
color: blue;
}

</style>

</head>
<body>
<div class="container">
<h1> Are you tall enough to ride the roller coaster</h1>
<img src="roller.png">
<div class="height">
<input type="text" id="height" placeholder="Please enter your height">
<input type="submit" value="sumbit" onclick=ride()>
</div>
</div>

if( ht >= 64). You mean to say if ht is greater than or equal to, not less than. — Vincent Ramdhanie
– Vincent Ramdhanie, Commented Nov 14, 2013 at 0:10
You probably want this: alert("You may go on the ride!!"); — Koen.
– Koen., Commented Nov 14, 2013 at 0:13

Castiblanco · Accepted Answer · 2013-11-14 00:09:55Z

0

Remember you want to show a String! You forgot " "

prompt("You may go on the ride!!");

answered Nov 14, 2013 at 0:09

Castiblanco

1,1984 gold badges13 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sionnach733 · Accepted Answer · 2013-11-14 00:19:11Z

0

It should be

if( ht >= 64){

not

if( ht <= 64)

and the " " in prompt, you should also consider using alert instead of prompt. prompt accepts an input from the user whereas alert just shows the message.

edited Nov 14, 2013 at 0:19

Sionnach733

4,7564 gold badges40 silver badges51 bronze badges

answered Nov 14, 2013 at 0:12

ImperialCereal

211 silver badge4 bronze badges

2 Comments

user2684242 Over a year ago

Thank you. I am still getting an alert: TypeError: 'undefined' is not an object (evaluating 'document.getElementById("height")[0].value')

user2684242 Over a year ago

It is also sending me an error about the function ride. Is there a better way to call the function other then onclick?

Karthik · Accepted Answer · 2013-11-14 00:30:17Z

0

You should place text in prompt() in parentheses like

 prompt("You may go on the ride!!");

Also it should be

  ht = document.getElementById("height").value;

document.getElementById("height") does not return a collection since "height" is an id and not a class. If you have declared like

  <input type="text" class="height" placeholder="Please enter your height">

and you can use

  ht = document.getElementsByClassName("height")[0].value;

edited Nov 14, 2013 at 0:30

answered Nov 14, 2013 at 0:23

Karthik

1421 silver badge6 bronze badges

Collectives™ on Stack Overflow

Simple javascript functions

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related