Passing a variable to a function using JQuery

Question

the following does NOT work:

function doRestyle(div) {
        jQuery(div).css({
            "margin-top": addableMargin + "px",
            "margin-bottom": addableMargin + "px",
        });
}

However, this works:

function doRestyle(div) {
        jQuery('#idName').css({
            "margin-top": addableMargin + "px",
            "margin-bottom": addableMargin + "px",
        });
}

Any explanation? Many thanks :)

It should work if the div is e.g. "#idName". Show how do you call doRestyle function. — DontVoteMeDown
– DontVoteMeDown, Commented Nov 5, 2013 at 10:26
Note that the trailing comma in your object literal will cause some older browsers to fail. Best to remove it. — lonesomeday
– lonesomeday, Commented Nov 5, 2013 at 10:27
What does div or jQuery(div) return in the console during the doRestlyle call? — Alberto De Caro
– Alberto De Caro, Commented Nov 5, 2013 at 10:28

nnnnnn · Accepted Answer · 2013-11-05 10:25:36Z

3

"Any explanation?"

Apparently when you call your function the argument you pass in (that becomes div) is not a string with the appropriate selector or a reference to the DOM element in question (or a jQuery object containing a reference to that element).

You would need to call your function like this:

doRestyle("#idName");

Or with some variable that has been set appropriately:

var id = "idName";
doRestyle("#" + id);

Or perhaps in an event handler:

$("#idName").click(function() {
    doRestyle(this);
});

Etc.

answered Nov 5, 2013 at 10:25

nnnnnn

150k30 gold badges210 silver badges247 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Lovely Pufferfish · Accepted Answer · 2013-11-05 10:34:06Z

0

function doRestyle(someID) {
        jQuery('#'+someID).css({
            "margin-top": addableMargin + "px",
            "margin-bottom": addableMargin + "px",
        });
}

:D

answered Nov 5, 2013 at 10:34

Lovely Pufferfish

71 bronze badge

Collectives™ on Stack Overflow

Passing a variable to a function using JQuery

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related