is there a way in JavaScript to use string+variable as a variable

Question

I did try to do this (with jQuery):

type = (blabla == blublu)? 'category':'regular';
(type+'Name').val('...');

this is the console response:

Uncaught TypeError: Object categoryName has no method 'val'

although they actually exist...

so how can I make it work??

edit:

this is the full function:

var type = (1 == 1)?'something':'blabla';

var somethingName = $('#somethingName');
var blablaName = $('#blablaName');
more variables like this..

function itemMode(mode, inputValue){
  inputValue = (typeof inputValue !== 'undefined')? inputValue:'';
  var functionName = null;
  switch(mode){
  case 'open':
    btnValue = 'something';
    functionName = editCategory; // this need to be from type to
    openItem = true;
    break;
  case 'close':
    btnValue = 'something';
    functionName = addCategory; // this need to be from type to
    openItem = false;
    break;
  default:
    return false;
  }
  (type+'Name').val(inputValue);
  $('#btn'+type.capitalize()).off('click').val(btnValue).click(functionName);
  (type+'Name').off('keypress').keypress(function(e){enterPress(e,functionName);});
}

i try (type+'Name') to crate reference to an existing var or object.

can you present your actual full jQuery code? And explain what exactly you want to get from where? — Top Questions
– Top Questions, Commented Nov 4, 2013 at 12:56
Assuming categoryName for example is an ID attribute, you would go $('#' + type + 'Name'). — Moo-Juice
– Moo-Juice, Commented Nov 4, 2013 at 12:58
Global variables are properties of the window object: window["foo"+"bar"] — C3roe
– C3roe, Commented Nov 4, 2013 at 12:59
Please clarify whether you want to deal with CSS selectors or Javascript variables. — user1636522
– user1636522, Commented Nov 4, 2013 at 13:12

T.J. Crowder · Accepted Answer · 2013-11-04 13:04:12Z

8

Your problem is not with the concatenation. That works fine. You concatenate type with 'Name', and you get the string 'categoryName'. You then do this:

('categoryName').val(...);

This is the same as 'categoryName'.val(...), which obviously won't work, because strings do not have a val method.

You are attempting to do a jQuery selection, for which you need the jQuery constructor:

$(type+'Name').val('...');

This, of course, is also unlikely to work, unless you have elements with the tag name categoryName. Presumably you actually want elements with that class:

$('.' + type + 'Name')

or id:

$('#' + type + 'Name')

or something similar.

edited Nov 4, 2013 at 13:04

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

answered Nov 4, 2013 at 12:57

lonesomeday

239k54 gold badges330 silver badges329 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

GoDLighT Over a year ago

ya i thought about it but ן'm trying to do a function that will fit some situations and this is not the only id thet influence form that function

Reinstate Monica Cellio · Accepted Answer · 2013-11-04 15:07:51Z

2

Variables are created as properties of the window object, so if they are global you can do this...

window[type + "Name"]

Since you want to refer to a "cached" jQuery object, use the following...

(window[type + "Name"]).val("123");

For example, if you've cached a jQuery object like this...

var sumVar = $('#sumid');

You can refer to it directly like this...

sumVar.val("123");

Or you can refer to it using a variable as the name, like this...

var varName = "sumVar";

(window[varName]).val("123");

Here's a modified version of the script you posted above...

var type = (1 == 1)?'something':'blabla';

window.somethingName = $('#somethingName');
window.blablaName = $('#blablaName');

function itemMode(mode, inputValue){
    inputValue = (typeof inputValue !== 'undefined')? inputValue:'';
    var functionName = null;
    switch(mode){
        case 'open':
            btnValue = 'something';
            functionName = editCategory; // this need to be from type to
            openItem = true;
            break;
        case 'close':
            btnValue = 'something';
            functionName = addCategory; // this need to be from type to
            openItem = false;
            break;
        default:
            return false;
    }

    (window[type + 'Name']).val(inputValue);

    $('#btn' + type.capitalize()).off('click').val(btnValue).click(functionName);

    (window[type + 'Name']).off('keypress').keypress(function(e){enterPress(e,functionName);});
}

edited Nov 4, 2013 at 15:07

answered Nov 4, 2013 at 12:57

Reinstate Monica Cellio

26.2k6 gold badges54 silver badges67 bronze badges

17 Comments

GoDLighT Over a year ago

it just i dont want to do this $('#sumid') in the function because i did it 2 lins before the function declared so i did $('#sumId') into sumVar and when i do sumVar.jQuerystuff() it work but when i try to expand my function to more same suff i need it to be variable

GoDLighT Over a year ago

I learned Programming not to repeat things twice, this is my goal

Reinstate Monica Cellio Over a year ago

Okay, I've updated the answer and I think it will help more.

Reinstate Monica Cellio Over a year ago

If you just want to refer to a cached jQuery object then just use the variable. var $body = $("body"); $body.hide(); - for example.

GoDLighT Over a year ago

I try my best but i do var sumVar = 123 and console.log(sumVar); return 123 and console.log(window[sumVar]); return undefined

|

Roko C. Buljan · Accepted Answer · 2013-11-04 13:13:40Z

0

You can create a function and use it's returned value:

_{DEMO1 DEMO2}

function type(){
  return (blabla == blublu) ? 'category' : 'regular';
}


$('[name="'+ type() +'Name"]').val('SOME VALUE');

If you use ID rather than name attribute:

function type(){
  return (blabla == blublu) ? '#category' : '#regular';
}


$( type() +'Name').val('SOME VALUE');

Or just simply:

var typeID =  blabla==blublu? '#category' : '#regular';
$( typeID +'Name').val('SOME VALUE');

edited Nov 4, 2013 at 13:13

answered Nov 4, 2013 at 13:06

Roko C. Buljan

209k41 gold badges335 silver badges346 bronze badges

Comments

Chimba · Accepted Answer · 2013-11-04 13:25:23Z

0

val() is a method provided by jquery. So to access it you will need to use the '$' operator along with the mode of selection :

var type = (blabla == blublu)? 'category':'regular';

For accessing using ID :

$("#"+type).val("...");

For accessing using Class :

$("."+type).val("...");

For accessing using any custom attribute for eg. data :

$("data['"+type+"']").val("...");

answered Nov 4, 2013 at 13:25

Chimba

1321 silver badge7 bronze badges

Comments

Daniel A. White · Accepted Answer · 2013-11-04 14:56:23Z

-2

You only can safely do that with an object key.

Create an object like so.

var obj = {
   'categoryName': ...

};

To retrieve it use something like this:

obj[someString]

eval is an option is not wise.

edited Nov 4, 2013 at 14:56

answered Nov 4, 2013 at 12:56

Daniel A. White

192k49 gold badges389 silver badges473 bronze badges

1 Comment

user1636522 Over a year ago

Do what? I'm sorry but your answer is as muddled as the question :/

Collectives™ on Stack Overflow

is there a way in JavaScript to use string+variable as a variable

edit:

5 Answers 5

1 Comment

17 Comments

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

edit:

5 Answers 5

1 Comment

17 Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related