create array of string builder instead of string

Question

I am creating an application in window application using c#. I have a string array,and its value will be updated in each timer tick event. later on ,i have to convert this array into object array. I know, if we are modifying string many times,it can be time consuming to create new string objects.so i want to use stringBuilder.

let say, in timer tick event:

for (int i = 0; i < 10; i++)
  {
     n[i] = i.ToString();
  }

where n is the string array and i want to use stringbuilder instead of array. is it possible? how do i do this? how do i convert stringBuilder type to object type?

If you want to convert into an object array, why are you converting to string first? Why not just use objects? — Matthew Watson
– Matthew Watson, Commented Oct 8, 2013 at 7:46
@MatthewWatson He means a non primitive, non value (reference type) — Sam Leach
– Sam Leach, Commented Oct 8, 2013 at 7:51

Henk Holterman · Accepted Answer · 2013-10-08 07:41:48Z

2

You do not need a StringBuilder here. A StringBuilder is only called for when processing (usually: concatenating) a single string many times. You have many small and unrelated strings.

What you probably want is to replace the array string[] with a List<string>.

answered Oct 8, 2013 at 7:41

Henk Holterman

276k33 gold badges353 silver badges540 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

mahua22 Over a year ago

I have to call this string array many times,program will run for 1-2 days continuously,and array will be called each timer tick.

Henk Holterman Over a year ago

You do not 'call' strings. If the code executes s += ..; for the same s many times, then use an SB.

Matthew Watson Over a year ago

@mahua22 Which makes no difference, you still do not need a StringBuilder.

Jeroen Vannevel · Accepted Answer · 2013-10-08 07:48:30Z

1

You can keep your array of strings and use a StringBuilder in the loop.

var myValues = new String[100];

void tick() {
 var sb = new StringBuilder();

 for (int i = 0; i < 10; i++){
  sb.append(i.ToString());
 }

 myValues.add(sb.ToString());
}

This adds all values in the range of 0 to 10 to one string. I don't know why you'd need this, so if you want to do something different you should clarify.

edited Oct 8, 2013 at 7:48

answered Oct 8, 2013 at 7:39

Jeroen Vannevel

44.6k25 gold badges113 silver badges174 bronze badges

Comments

Pawan · Accepted Answer · 2013-10-08 07:40:22Z

0

You can do something like this

 StringBuilder obj=new StringBuilder();

    for (int i = 0; i < 10; i++)
      {
          obj.append(i.ToString());
      }

answered Oct 8, 2013 at 7:40

Pawan

1,0855 silver badges10 bronze badges

1 Comment

mahua22 Over a year ago

its creating a long long string. i want to store it as array. at each timer tick,value of each index will be changed.

Tim Schmelter · Accepted Answer · 2013-10-08 07:51:41Z

0

Here is another approach that does not need to use an array or StringBuilder and which should be efficient enough if the sequence is not too large:

string nums = String.Join("", Enumerable.Range(0, 10));

However, string.Join is really efficient if the input is already an array. In this case it might really be more efficient to use a StringBuilder:

string nums =  Enumerable.Range(0, 10)
    .Aggregate(new StringBuilder(), (a, b) => a.Append(b))
    .ToString();

edited Oct 8, 2013 at 7:51

answered Oct 8, 2013 at 7:45

Tim Schmelter

462k79 gold badges719 silver badges980 bronze badges

Comments

Adarsh Kumar · Accepted Answer · 2013-10-08 07:54:56Z

I would suggest you to use code something like :

class Program
{
    static void Main(string[] args)
    {
        var dic = new Dictionary<int, StringBuilder>();

        //Initialize dictionary
        for (int i = 0; i < 10; i++)
        {
            dic.Add(i, new StringBuilder());
        }

        TimerElapsed(dic);

        TimerElapsed(dic);

        Process(dic.Values.ToArray());
    }

    public static void Process(object[] objects)
    {
        //Do your processing
    }

    public static void TimerElapsed(IDictionary<int, StringBuilder> dic)
    {
        for (int i = 0; i < 10; i++)
        {
            dic[i].Append(i.ToString());
        }
    }
}

Such code will give you benefits of collection and flexibility (for eg: you could convert to array easily)

Collectives™ on Stack Overflow

create array of string builder instead of string

5 Answers 5

3 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

3 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related