Event Driven programming - non linear code

Question

I have the following code (logic) in PHP:

$fp = fopen('fp.txt', 'w');
    if ($msg == 'say') {
        fwrite($fp, 'Hello world!');
    }
$msg = 'done';

To convert this into asynchronous event driven code, the author of node for PHP developers suggests I refactor it like this.

$fp = fopen('fp.txt', 'w');
if ($msg == 'say') {
    fwrite($fp, 'Hello world!');
    $msg = 'done';
} else {
    $msg = 'done';
}

And then,

fs.open('fp.txt', 'w', 0666, function(error, fp) {
    if (msg == 'say') {
        fs.write(fp, 'Hello world!', null, 'utf-8', function() {
        msg = 'done';
    });
    } else {
        msg = 'done';
    }
});

You'd clearly see, there is code duplication. 'msg = "done"' is repeated. Can this be avoided? Code duplication is bad practice right?

Is event driven programming always like this?

Connor Peet · Accepted Answer · 2013-09-13 02:32:49Z

2

Like this:

var done = function() {
    msg = 'done';
};

fs.open('fp.txt', 'w', 0666, function(error, fp) {
    if (msg == 'say') {
        fs.write(fp, 'Hello world!', null, 'utf-8', done);
    } else {
        done();
    }
});

answered Sep 13, 2013 at 2:32

Connor Peet

6,2833 gold badges24 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Event Driven programming - non linear code

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related