ConcurrentModificationException when using iterators

Question

I have this java code that iterates over ArrayList of objects and remove some records from it, but I have a ConcurrentModificationException, here is my code.

for (ServiceWorkFlowStepModel s : svcModel.getServiceModel().getWorkFlowSteps()) {
                    if (s.getStepOrder().equals(stepIndex + 1)) {
                        svcModel.getServiceModel().getWorkFlowSteps().remove(s);
                    }
                    Iterator<ActivityModel> iter = activities.iterator();
                    while (iter.hasNext()) {
                        ActivityModel am = iter.next();
                        if (am.getComponentModel().getComponenetId().equals(s.getComponentId())) {
                            iter.remove();
                        }
                    }
                }

your problem is the first remove, where you are not using the iterator, but the for each. — dognose
– dognose, Commented Sep 12, 2013 at 20:28
Possible duplicate of Iterating through a Collection, avoiding ConcurrentModificationException when removing in loop — Raedwald
– Raedwald, Commented Mar 28, 2016 at 14:49

kosa · Accepted Answer · 2013-09-12 20:28:50Z

4

for-each loop is built on iterators, below code modifies your collection while iterating, which is why you are getting ConcurrentModificationException.

if (s.getStepOrder().equals(stepIndex + 1)) {
                        svcModel.getServiceModel().getWorkFlowSteps().remove(s);
              }

One approach to solve this issue would be use iterator instead of for-each and call remove() on iterator like you did in later section of your code.

answered Sep 12, 2013 at 20:28

kosa

66.7k15 gold badges134 silver badges170 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rohit Jain · Accepted Answer · 2013-09-12 20:29:26Z

2

The problem I guess is not in the iterators, but it's in the if block:

if (s.getStepOrder().equals(stepIndex + 1)) {
    svcModel.getServiceModel().getWorkFlowSteps().remove(s);
}

If your method svcModel.getServiceModel().getWorkFlowSteps() returned a reference to the same container (I mean, if you didn't return a defensive copy of list or whatever it is from that method), then you are actually modifying the same container you are iterating upon, though with a different reference. That is why you get that exception.

So, you should also change the outer loop to using iterators.

answered Sep 12, 2013 at 20:29

Rohit Jain

214k45 gold badges419 silver badges534 bronze badges

Collectives™ on Stack Overflow

ConcurrentModificationException when using iterators

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related