Problem in php upload script?

Question

 function getExtension($str) {
         $i = strrpos($str,".");
         if (!$i) { return ""; }
         $l = strlen($str) - $i;
         $ext = substr($str,$i+1,$l);
         return $ext;
 }

define ("MAX_SIZE","2000"); 

if( isset($_FILES['file_upload']))
 {

$errors=0;
$image=$_FILES['file_upload']['name'];
if ($image) 
{
    $filename = stripslashes($_FILES['file_upload']['name']);
    $extension = getExtension($filename);
    $extension = strtolower($extension);
    if (($extension != "jpg") && ($extension != "bmp") && ($extension != "png") && ($extension != "gif")) 
        {
            echo '<h1>Unknown extension!</h1>';
            $errors=1;
        }
    else
        {
            $size=filesize($_FILES['file_upload']['tmp_name']);
            if ($size > MAX_SIZE*1024)
            {
                echo '<h1>You have exceeded the size limit!</h1>';
                $errors=1;
            }
                $random_name=md5(uniqid(mt_rand(), true)).'.'.$extension;   
                $from=$_FILES['file_upload']['tmp_name'];               
                $newname='"temp_images/'.$random_name.'"';                      
                rename($from, $newname);     Problm is here?????
                                    //move_uploaded_file($from, $newname); Even tried this

            }   
}

}

I dont know why images are not moving in temp_images folder..Can anybody help me.Thanks in advance.

Edit:

HTML FORM:

 <form name="form_upload" action="<?=$PHP_SELF?>"  method="post" enctype="multipart/form-data">
                                        <table   class='nryo_modal_div_table' align='center'>
<tr>
<td align='left'  class='response_color_ok'>
Select File:
    </td>                                               </tr>                                       <tr>

Can you post your html form too?

Jage
– Jage

2009-12-07 07:35:33 +00:00
Commented Dec 7, 2009 at 7:35 — Jage
– Jage, Commented Dec 7, 2009 at 7:35

Sarfraz · Accepted Answer · 2009-12-07 07:38:21Z

1

Make sure that temp_images folder has write permissions; chmod to 755.

Also make sure that you have specified enctype=multipart on the form used to upload the images.

answered Dec 7, 2009 at 7:38

Sarfraz

384k81 gold badges561 silver badges613 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Mohit Jain Over a year ago

I never cared about the permissions of a folder, i m using windows and apache and we just create a folder and write the code acc to that. by default every time when i use code like this, it always worked..I dont know what happenin this time

jaywon Over a year ago

If that code has always worked before, and is not working on a new folder or project, it is almost definitely a permissions problem.

Sarfraz Over a year ago

you need to use ftp client software to change permissions by right clickingon folder and typing 755 also make sure that your form has enctype set to multipart. Thanks

jaywon · Accepted Answer · 2009-12-07 19:30:16Z

0

You may want to try using the move_uploaded_file function instead of the rename function. As noted by sarfraz, also check that the temp_images folder has the proper permissions set.

Something like this is what I usually do:

if(move_uploaded_file($_FILES['file_upload']['tmp_name'], $newname)) {
  //move okay
}else{
  //move not okay
}

To change a folder's permissions programmatically take a look at the PHP function chmod()

edited Dec 7, 2009 at 19:30

answered Dec 7, 2009 at 7:41

jaywon

8,27410 gold badges42 silver badges47 bronze badges

1 Comment

jaywon Over a year ago

to change permissions on a folder programmitcally take a look at the chmod() function in PHP

Collectives™ on Stack Overflow

Problem in php upload script?

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related