Regex to replace url in html page

Question

i have an html page

<tr>
<td rowspan="7">
<a href="http://www.link1.com/" style="text-decoration: none;">
        <img src="image1.jpg" width="34" height="873" alt="" style="display:block;border:none" />
        </a>
    </td>
    <td colspan="2" rowspan="2">
        <a href='http://www.link1.com/test.php?c=1'>
        <img src="image1.jpg" width="287" height="146" alt="" style="display:block;border:none" />
        </a>
    </td>
<td colspan="2" rowspan="2">
        <a href='http://www.url.com/test.php?c=1'>
        <img src="image1.jpg" width="287" height="146" alt="" style="display:block;border:none" />
        </a>
    </td>

I want to replace all url in href by mytest.com?url=$link

I try with :

    $messaget = preg_replace('/<a(.*)href="([^"]*)"(.*)>/','mytest.com?url=$2',$messaget);

PHP is server-side code... so I'm not sure what/how you're trying to accomplish your result. — adamdehaven
– adamdehaven, Commented Aug 29, 2013 at 16:05
You should never use regex for dealing with HTML code, use an HTML parser instead. See stackoverflow.com/questions/3577641/… and simplehtmldom.sourceforge.net. — Technoh
– Technoh, Commented Aug 29, 2013 at 16:17

Community · Accepted Answer · 2017-05-23 12:06:01Z

1

This may help you in the short run:

preg_replace('/<a (.*)href=[\'"]([^"]*)[\'"](.*)>/', '<a $1href="mytest.com?url=$2"$3>', $messaget);

In your regex you were using href="...", that is, double quotes, but in your HTML you have a mixture of both double and single quotes.

And in the replacement string you forgot to include $1 and $3.

That said, DO NOT use regex to parse HTML. The answer by @BenLanc below is better, use that instead. Read the link he posted.

edited May 23, 2017 at 12:06

CommunityBot

11 silver badge

answered Aug 29, 2013 at 16:14

janos

126k31 gold badges242 silver badges253 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Kieran Over a year ago

His regex works only for double quotes the issue is he needs to account for both double and single as per his supplied sample. So the regex you've provided still won't do the job. Though you did fix the replacement error

janos Over a year ago

You're right. I didn't see earlier that he had also with double quotes, I saw only single quotes. Thanks, will fix now.

BenLanc Over a year ago

@janos It's cool, undid the downvote and deleted my comment when you updated your answer

Community · Accepted Answer · 2017-05-23 11:43:45Z

Don't use regex on HTML, HTML is not regular.

Assuming your markup is valid (and if it's not, pass it through Tidy first), you should use xpath, to grab the elements and then update the href directly. For example:

<?php
$messaget = <<<XML
<tr>
  <td rowspan="7">
    <a href="http://www.link1.com/" style="text-decoration: none;">
      <img src="image1.jpg" width="34" height="873" alt="" style="display:block;border:none" />
    </a>
  </td>
  <td colspan="2" rowspan="2">
      <a href='http://www.link1.com/test.php?c=1'>
      <img src="image1.jpg" width="287" height="146" alt="" style="display:block;border:none" />
      </a>
  </td>
  <td colspan="2" rowspan="2">
      <a href='http://www.url.com/test.php?c=1'>
      <img src="image1.jpg" width="287" height="146" alt="" style="display:block;border:none" />
      </a>
  </td>
</tr>
XML;

$xml   = new SimpleXMLElement($messaget);

// Select all "a" tags with href attributes
$links = $xml->xpath("//a[@href]");

// Loop through the links and update the href, don't forget to url encode the original!
foreach($links as $link)
{
  $link["href"] = sprintf("mytest.com/?url=%s", urlencode($link['href']));
}

// Return your HTML with transformed hrefs!
$messaget = $xml->asXml();

robinef · Accepted Answer · 2013-08-29 16:18:01Z

0

Don't forget /m at the end of your regexp since your are using multiline source:

PHP Doc PCRE

answered Aug 29, 2013 at 16:18

robinef

3121 silver badge7 bronze badges

Comments

lordkain · Accepted Answer · 2013-08-29 16:22:50Z

0

Regex to match an url:

/^(https?:\/\/)?([\da-z\.-]+)\.([a-z\.]{2,6})([\/\w \.-]*)*\/?$/

More background info

edited Aug 29, 2013 at 16:22

answered Aug 29, 2013 at 16:15

lordkain

3,1191 gold badge16 silver badges18 bronze badges

Collectives™ on Stack Overflow

Regex to replace url in html page

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related