Why is my javascript module returning undefined when I try to access variables?

Question

I have a javascript module that neatly separates data from dom and returns a public api for its data and ui objects:

var PtCalcApp = (function() {
    var ptCalc = ptCalc || {};

    ptCalc.ui = {
        storage: $('#pt-storage'),
        backup: {
            daily: $('#per-day-data'),
            weekly: $('#per-week-data'),
            monthly: $('#per-month-data'),
            yearly: $('#per-year-data')
        },
        change: {
            yearly: $('#annual-change'),
            daily: $('#daily-change')
        }
    };

    ptCalc.data = {
        storage: function() {
            ptCalc.ui.storage.val()
        }
    }

    return ptCalc;
})();

Now when I try to access data like this this:

PtCalcApp.data.storage()

it returns undefined. What am I doing wrong with this self invoking function pattern? How do I fix this?

You are storing the data directly in the DOM in visual format, I don't see the separation. — Esailija
– Esailija, Commented Jun 19, 2013 at 10:21
Ok can you show me a better way to do this without using a mvc framework? — Amit Erandole
– Amit Erandole, Commented Jun 19, 2013 at 10:21
You are right - that fixed the ui access issue - but now I am still not getting my storage input data when I call PtCalcApp.data.storage() - I get undefined — Amit Erandole
– Amit Erandole, Commented Jun 19, 2013 at 10:26

Felix Kling · Accepted Answer · 2013-06-19 10:28:31Z

1

You are not returning anything from the function. Without a return statement, the function will return undefined (unless called with new, but that's a different matter).

storage: function() {
    ptCalc.ui.storage.val()
}

should be

storage: function() {
    return ptCalc.ui.storage.val()
}

answered Jun 19, 2013 at 10:28

Felix Kling

820k181 gold badges1.1k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arun P Johny · Accepted Answer · 2013-06-19 10:17:11Z

0

PtCalcApp.ui.storage is not a function, it is a property.

You need to access it using PtCalcApp.ui.storage not as PtCalcApp.ui.storage()

If you want to use a a function then you need to declare it as

storage: function(){
    return $('pt-storage');
}

answered Jun 19, 2013 at 10:17

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

3 Comments

Amit Erandole Over a year ago

Sorry, I made mistake in posting the code I was accessing it as PtCalcApp.ui.storage - It doesn't work

Arun P Johny Over a year ago

@AmitErandole looks like you are missing # in front of pt-storage

Amit Erandole Over a year ago

You are right - I fixed that but there is still the problem with not getting my data back

Collectives™ on Stack Overflow

Why is my javascript module returning undefined when I try to access variables?

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related