Shell script using curl to loop through urls

Question

I've been trying to create a simple script that will take a list of queries from a .txt file, append the main url variable, then scrape the content and output it to a text file.

Here's what I have so far:

#!/bin/bash

url="example.com/?q="
for i in $(cat query.txt); do
    content=$(curl -o $url $i)
    echo $url $i
    echo $content >> output.txt
done

list:

images
news
stuff
other

error log:

curl: (6) Could not resolve host: other; nodename nor servname provided, or not known
example.com/?q= other

If I use this command straight from the command line I get some output into the file:

curl -L http://example.com/?q=other >> output.txt

Ultimately I would like the output to be:

fetched:    http://example.com/?q=other
content:    the output of the page

followed by the next query in the list.

Gilles Quénot · Accepted Answer · 2013-04-21 12:58:41Z

37

Use more quotes !

Try this instead :

url="example.com/?q="
for i in $(cat query.txt); do
    content="$(curl -s "$url/$i")"
    echo "$content" >> output.txt
done

answered Apr 21, 2013 at 12:58

Gilles Quénot

188k43 gold badges232 silver badges229 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mena Ortega Over a year ago

I guess that should have been painfully obvious. :p Thanks very much! :)

Arun Over a year ago

each iteration, the previous output is clearing from output.txt? do you know how to keep it?

David George · Accepted Answer · 2013-04-21 13:07:35Z

5

You've got nested quotes, try something like this:

#!/bin/bash

url=https://www.google.fr/?q=
while read query
do
    content=$(curl "{$url}${query}")
    echo $query
    echo $content >> output.txt
done < query.txt

answered Apr 21, 2013 at 13:07

David George

3,7521 gold badge21 silver badges22 bronze badges

Collectives™ on Stack Overflow

Shell script using curl to loop through urls

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related