passing url as parameter in javascript is not calling the function

Question

<a href="javascript:void();" onclick="openWindow(2,1,4326,http://www.../images/icon_tree1.gif);">Edit Asset Info</a>

Function openWindow is not called and I am see the folowing error on console

Uncaught SyntaxError: Unexpected token : and

Uncaught SyntaxError: Unexpected token )

This is the actual code I am using

return "<a href='javascript:void();' onclick='openWindow(" 2 "," + 1 + "," + 4326 + "," + symbolurl + ");'>Edit Asset Info</a>";

http://www.unm.edu/~jka/courses/images/icon_tree1.gif is not a JavaScript string literal. Try again. (Hint: compare x with 'x') — user2246674
– user2246674, Commented Apr 19, 2013 at 20:16

VisioN · Accepted Answer · 2013-04-19 20:16:25Z

2

URL address is a string, so you should surround it with quotes:

... onclick="openWindow(2,1,4326,'http://www.../images/icon_tree1.gif');" ...

answered Apr 19, 2013 at 20:16

VisioN

146k35 gold badges287 silver badges291 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

NoodleFolk · Accepted Answer · 2013-04-19 20:41:39Z

0

You need to pass a string to the onclick handler onclick="openWindow(1, 2, 3, 'http://...')" Some other comments:
1, If your anchor doesn't actually take the user anywhere, consider not to use <a> rather than href="javascript:void();"
2, try not to mix javascript with html. so link your event handler to the DOM element in a <script> tag.

answered Apr 19, 2013 at 20:41

NoodleFolk

2,0692 gold badges17 silver badges24 bronze badges

Collectives™ on Stack Overflow

passing url as parameter in javascript is not calling the function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related