Problem with the ArrayList class in Java

Question

I have a problem with the following code. I obtain the error message

Exception in thread "main" java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
    at java.util.ArrayList.rangeCheck(ArrayList.java:571)
    at java.util.ArrayList.set(ArrayList.java:364)
    at Test.main(Test.java:17)

and I don't understand why. I have a list, which is initialised, then I iterate over it, and then I want to fill another list with the values of the first list. I don't understand why I get IndexOutOfBoundsException. It seems that my initialisation is not correct. Thanks a lot in advance.

public static void main(String[] args) {

        String s1 = "one";
        String s2 = "one";
        ArrayList list = new ArrayList();
        list.set(0, s1);
        list.set(1, s2);
        Iterator it = list.iterator();
        ArrayList listToFill = new ArrayList();
        int k = 0;
        while (it.hasNext()) {
            String m = "m";
            listToFill.set(k, m);
            k++;
        }

    }

tster · Accepted Answer · 2009-09-27 16:23:52Z

11

You are using the wrong method to add items.

Either:

list.add(0, s1);
list.add(1, s2);

or preferably:

list.add(s1);
list.add(s2);

set tries to replace the item that is currently there, but nothing is there yet.

More info

answered Sep 27, 2009 at 16:23

tster

18.3k6 gold badges57 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alberto Zaccagni · Accepted Answer · 2009-09-27 16:24:49Z

3

You never use

it.next();

Maybe this is not the point, but I don't think you want an infinite loop.

answered Sep 27, 2009 at 16:24

Alberto Zaccagni

31.8k11 gold badges75 silver badges108 bronze badges

1 Comment

user42155 Over a year ago

Thanks a lot, that was my next mistake, which I haven't thought of. It is working now :)

duffymo · Accepted Answer · 2009-09-27 16:30:31Z

0

Why on earth would you write this to copy one List into another?

This is far more succinct:

import java.util.ArrayList;
import java.util.List;

public class ListDemo
{
   public static void main(String[] args)
   {

      List<String> l1 = new ArrayList<String>(args.length);
      for (String arg : args)
      {
         l1.add(arg);
      }
      System.out.println("l1: " + l1);
      List<String> l2 = new ArrayList<String>(l1);
      System.out.println("l2: " + l2);
   }
}

answered Sep 27, 2009 at 16:30

duffymo

310k46 gold badges376 silver badges570 bronze badges

2 Comments

Stefan Kendall Over a year ago

Even better: Collections.copy( l2, l1 );

Tom Hawtin - tackline Over a year ago

List<String> l1 = Arrays.asList(args); List<String> l2 = new ArrayList<String>(l1);

Thorbjørn Ravn Andersen · Accepted Answer · 2009-09-27 22:08:04Z

0

When you have a stack trace thn USE it to figure out where the crash happened! Here the put() is a dead giveaway to reinvastigate in the javadoc.

answered Sep 27, 2009 at 22:08

Thorbjørn Ravn Andersen

75.4k35 gold badges203 silver badges359 bronze badges

Collectives™ on Stack Overflow

Problem with the ArrayList class in Java

4 Answers 4

Comments

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related