rails select method iterating array

Question

I am new at ruby and rails and on my studies I've created this Payment Types array of my Order..

class Order < ActiveRecord::Base

  PAYMENT_TYPES = [{:id => "check", :name => "Check"}, {:id => "credit_card", :name => "Credit card"}, {:id => "purchase_order", :name => "Purchase order"}]

and I would like to use this way

<%= f.select :pay_type, Order::PAYMENT_TYPES.each {|order| [order.name, order.id]}, :prompt => 'Select a payment method' %>

but I'm getting this error

undefined method `name' for {:id=>"check", :name=>"Check"}:Hash

what is wrong?

vpsz · Accepted Answer · 2012-11-24 22:11:22Z

2

In your each block, the variable order is being filled each time with a hash. Therefore you need to access it like a hash with order[:name] and order[:id] instead of .name and .id.

Edit

Also, for maintainability, you may want to create a separate PaymentType model. This will give you much more power and flexibility. With your current method, what happens if you want to add or remove a payment type later? You'll have to edit the source code. What if you only want certain payment methods to be available for certain transactions?

answered Nov 24, 2012 at 22:11

vpsz

4573 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

thiagoh Over a year ago

thanks vpsz! but tell me which method should I call instead of .each that returns only that array I need like [['check', 'Check], ['credit_card', 'Credit Card']] ??

vpsz Over a year ago

Ah, I didn't even notice that error before. You want to use the 'map' method. each simply calls the block for every item in the array (like a foreach loop), whereas map runs the block on each of the elements then returns an array of the results (basically transforms the array using the function you provide in the block). Using .each and .map will be like 95% of what you do in RoR.

Collectives™ on Stack Overflow

rails select method iterating array

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related