Android SQLite database query

Question

I'm creating an android app that requires database connectivity, for which I'm using the inbuilt SQLiteDatabase class. My database has been created using the following statement:-

SQLiteDatabase db;
db = openOrCreateDatabase("ContactsMain",SQLiteDatabase.CREATE_IF_NECESSARY,null);
db.execSQL("Create Table Contacts (name Text, phno Text PRIMARY KEY, important Integer)");

'important' has values of either 0 or 1, based on whether the contact is important. To update this value, I'm using the following code:

protected void onListItemClick(ListView l, View v, int position, long id) {
    super.onListItemClick(l, v, position, id);
    c.moveToPosition(position);
    String ph = c.getString(c.getColumnIndex("phno"));
    ContentValues val = new ContentValues();
    val.put("important",1);
    String query = "update Contacts set important = 1 where phno=" + ph + ";";
    db.update("Contacts", val, query, null);
    c.close();
    db.close();
}

db and c have been initialized as follows:

SQLiteDatabase db = openOrCreateDatabase("ContactsMain",SQLiteDatabase.CREATE_IF_NECESSARY,null);
Cursor c = db.rawQuery("SELECT * FROM Contacts",null);

Problem is, when I click on an item in the list, the value of 'important' is set to 1 for all contacts, not just the one selected. Could someone help me out here?

Justgive important value as dynamically

RajeshVijayakumar
– RajeshVijayakumar

2012-11-14 05:40:21 +00:00
Commented Nov 14, 2012 at 5:40 — RajeshVijayakumar
– RajeshVijayakumar, Commented Nov 14, 2012 at 5:40
@ADR : Could you elaborate? I don't understand.

Abishek Ramasubramanian
– Abishek Ramasubramanian

2012-11-14 05:51:56 +00:00
Commented Nov 14, 2012 at 5:51 — Abishek Ramasubramanian
– Abishek Ramasubramanian, Commented Nov 14, 2012 at 5:51

RajeshVijayakumar · Accepted Answer · 2012-11-14 05:54:58Z

1

This will work for you

protected void onListItemClick(ListView l, View v, int position, long id) {
   super.onListItemClick(l, v, position, id);


  c.moveToPosition(position);
  String ph = c.getString(c.getColumnIndex("phno"));

  String where = "phno=?";
  String[] whereArgs = new String[] {ph};    

  ContentValues val = new ContentValues();
  val.put("important",1);

  db.update(DATABASE_TABLE, val, where, whereArgs);
  c.close();
  db.close();

}

answered Nov 14, 2012 at 5:54

RajeshVijayakumar

10.7k12 gold badges60 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Gene Over a year ago

This will update all the records in the database, not just one.

Philip Sheard Over a year ago

This looks good to me, except that I do not think you should be closing the cursor here.

Abishek Ramasubramanian Over a year ago

All the records are being updated, and that is the problem! I want only the item selected from the list to be updated. How do I do that? I tried the approach given in the first answer, still didn't work.

Gene · Accepted Answer · 2012-11-14 05:57:10Z

0

You want

ContentValues val = new ContentValues();
val.put("important", 1);
db.update("Contacts", val, "phno=?", new String[] {ph});

answered Nov 14, 2012 at 5:57

Gene

47.1k4 gold badges64 silver badges101 bronze badges

Collectives™ on Stack Overflow

Android SQLite database query

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related