Php undefined offset error

Question

Running the following code:

        preg_match("/^top\-sites\-csv\_(.+)\_/i", $file, $matches);
    $site_id = $matches[1];

And it keeps generating this notice:

PHP Notice:  Undefined offset

I guess its happening when the regex does not find a match. problem is that the script is on a cron and my error log grows huge in no time and then needs manual cleaning..

its like preg_match($pattern, $subject, $matches, PREG_OFFSET_CAPTURE, 3); — Mayank K. Swami
– Mayank K. Swami, Commented Nov 5, 2012 at 8:28
Add an if block to see if the array key exists, and if not, substitute something else for the site id? — Daedalus
– Daedalus, Commented Nov 5, 2012 at 8:28
You could do if (preg_match($pattern, $text, $matches)) to check if there were any matches. — air4x
– air4x, Commented Nov 5, 2012 at 8:31

Community · Accepted Answer · 2023-11-17 19:32:19Z

2

just check $matches using isset() before working with ist:

if(isset($matches[1])){
  $site_id = $matches[1];
  // do more here
}

edited Nov 17, 2023 at 19:32

CommunityBot

11 silver badge

answered Nov 5, 2012 at 8:29

oezi

51.9k10 gold badges102 silver badges119 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ghostman · Accepted Answer · 2012-11-05 08:30:08Z

0

If preg_match did not find a match, $matches is an empty array. So you should check if preg_match found an match before accessing $matches[1]

answered Nov 5, 2012 at 8:30

Ghostman

6,1129 gold badges36 silver badges53 bronze badges

Collectives™ on Stack Overflow

Php undefined offset error

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related