Implementing link in PHP foreach loop

Question

Trying to implement links in my foreach loop. However, can't get the $category link working. Any pointers? Managed to get the link to work for the sub-category, as shown below:

<?
$output = mysqli_query("SELECT * FROM bikes, bikeTypes WHERE bikes.model_id = bikeTypes.model_id");
$result = array();
while($row = mysqli_fetch_array($output))
{
   $result[$row['model']][] = $row;
}

foreach ($result as $category => $values) {
  echo "<li>".$category.'<ul>';
    foreach ($values as $value) {
      echo "<a href='details.php?id=" . $row['model_id'] . "'><li>" . $value['bikeName'] . "</a></li>";
    }
echo '</ul>';   
echo '</li>';
}
?>

Thanks for the help in advance guys! :)

the website concerned is mattmaclennan.co.uk/a2 if that helps! — Matt Maclennan
– Matt Maclennan, Commented Oct 30, 2012 at 21:37

ynh · Accepted Answer · 2012-10-30 21:38:05Z

4

The HTML Tags are not in the correct order first commes the li-tag and then the a-tag

  foreach ($values as $value) {
      echo "<li><a href='details.php?id=" . $row['model_id'] . "'>" . $value['bikeName'] . "</a></li>";
    }

answered Oct 30, 2012 at 21:38

ynh

2,9491 gold badge21 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Olaf Dietsche · Accepted Answer · 2012-10-30 21:39:25Z

2

Your a and li tags are intertwined:

<a><li>...</a></li>

this should be:

<li><a>...</a></li>

answered Oct 30, 2012 at 21:39

Olaf Dietsche

74.4k9 gold badges113 silver badges214 bronze badges

Collectives™ on Stack Overflow

Implementing link in PHP foreach loop

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related