Replace all commas in a string with JQuery/Javascript

Question

I have a form where I have a couple hundred text boxes and I'd like to remove any commas when they are loaded and prevent commas from being entered. Shouldn't the follow code work assuming the selector is correct?

$(document).ready(function () {
  $("input[id*=_tb]")
  .each(function () {
      this.value.replace(",", "")
  })
  .onkeyup(function () {
      this.value.replace(",", "") 
  })
});

Did you try the above code, and if so, what was the outcome? — jos
– jos, Commented Aug 21, 2012 at 13:00
I'd suggest using input event instead of keyup. Your protection can be overcome by pasting commas by rightclick->contextmenu->paste, which won't trigger keyup. — Imp
– Imp, Commented Aug 21, 2012 at 13:02

totallyNotLizards · Accepted Answer · 2015-03-09 13:56:13Z

36

$(function(){
    $("input[id*=_tb]").each(function(){
        this.value=this.value.replace(/,/g, "");
    }).on('keyup', function(){
        this.value=this.value.replace(/,/g, "");
    });
});

See here for an explanation and examples of the javascript string.replace() function:

http://davidwalsh.name/javascript-replace

as @Vega said, this doesn't write the new value back to the textbox - I updated the code to do so.

edited Mar 9, 2015 at 13:56

answered Aug 21, 2012 at 13:01

totallyNotLizards

8,5899 gold badges54 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Yoshi Over a year ago

the each could be replaced with $("input[id*=_tb]").val(function (_, val) { return val.replace(/,/g, ''); }), though it won't make much of a difference in this scenario.

Yoshi Over a year ago

one should most certainly use on('keyup', ... as onkeyup is no valid jQuery method. (see the comments on Vegas answer ;))

sp00m · Accepted Answer · 2012-08-21 13:01:36Z

5

Use a regex with the g flag instead of a string: .replace(/,/g, "").

answered Aug 21, 2012 at 13:01

sp00m

49k31 gold badges152 silver badges263 bronze badges

Comments

Selvakumar Arumugam · Accepted Answer · 2012-08-21 13:01:48Z

2

Your code looks right except that it is not setting the value back to the input field,

$(document).ready(function () {
  $("input[id*=_tb]")
  .each(function () {
      this.value = this.value.replace(/,/g, "")
  })
  .onkeyup(function () {
      this.value = this.value.replace(/,/g, "") 
  })
});

Edit: Used regex

answered Aug 21, 2012 at 13:01

Selvakumar Arumugam

79.9k15 gold badges123 silver badges139 bronze badges

1 Comment

Selvakumar Arumugam Over a year ago

@duckmike You should track back on error stack to see where the error is triggered from your code..

Collectives™ on Stack Overflow

Replace all commas in a string with JQuery/Javascript

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related