Basic Javascript issue (adding value)

Question

Here's my fiddle :

I'm not sure to understand why this code is not working.

What I want to add +1 to the "ajout" variable when I click on the "+1" button. And if ajout = 5 (after 5 clicks)...then alert("Hello");

Why am I doing wrong?

Here's my code :

HTML :

<input type="button" onclick="clickit();" id="click1" value="+1"/>

JS :

var ajout = 0;
function clickit()
{
 ajout +=1;    
}

if (ajout==5)
{
alert("TEST");   
}

Thank you!

What happens? What's the code that doesn't look work like? Please try to post details here as well as having a fiddle :) — Dave Newton
– Dave Newton, Commented Jun 20, 2012 at 18:17
Can you add the code in question here so the question gets perserved for future generations to look to for inspiration? (links go bad over time) — Jake1164
– Jake1164, Commented Jun 20, 2012 at 18:18
The code has been added. Why am I getting a -1? Can't a beginner ask questions here? Thank you — larin555
– larin555, Commented Jun 20, 2012 at 18:22

iMom0 · Accepted Answer · 2012-06-20 18:21:42Z

4

I think this is what you want:

var ajout = 0;
function clickit()
{
    ajout += 1;

    if (ajout==5)
    {
        alert("TEST");   
    }   
}

answered Jun 20, 2012 at 18:21

iMom0

12.9k3 gold badges52 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Sarfraz Over a year ago

+1 this is the correct answer, if condition was never executing on click event since it was outside of function which is triggered on click.

larin555 Over a year ago

Thank you, it's working. I studied the way you made it work and I understand it now. Thanks again

breln · Accepted Answer · 2012-06-20 18:17:47Z

1

I suppose it should be

ajout += 1;

And what you have is

=+

answered Jun 20, 2012 at 18:17

breln

316 bronze badges

1 Comment

Sarfraz Over a year ago

No that's not the issue you can use either

Nishu Tayal · Accepted Answer · 2012-06-20 18:23:55Z

1

Try this :

var ajout = 0;
jQuery('#click1').click(function(){
    ajout += 1;    
    console.log(ajout);
    if (ajout==5)
    {
    alert("TEST");   
    }
});

Here is the Demo

answered Jun 20, 2012 at 18:23

Nishu Tayal

20.9k8 gold badges53 silver badges105 bronze badges

Comments

jsalonen · Accepted Answer · 2012-06-20 18:27:08Z

1

Select "no wrap (body)" option from jsfiddle. Otherwise clickit function is defined only after DOM has loaded, which means it could never get executed.

Also make sure to put that alert inside clickit function to make sure it gets executed when you call that function.

edited Jun 20, 2012 at 18:27

answered Jun 20, 2012 at 18:18

jsalonen

30.7k15 gold badges93 silver badges111 bronze badges

1 Comment

jsalonen Over a year ago

The alert call is not placed inside clickit, but is instead executed when the script is loaded. Move it inside clickit and it will be executed!

Charles · Accepted Answer · 2012-06-20 18:22:11Z

0

Try This:

<input type="button" onclick="clickit();" id="click1" value="+1"/>
<script>
var ajout = 0;
function clickit()
{
 ajout += 1;    
    if (ajout==5)
    {
        alert("TEST");   
    }
}

</script>

answered Jun 20, 2012 at 18:22

Charles

6482 gold badges9 silver badges24 bronze badges

Comments

Ben A. Hilleli · Accepted Answer · 2012-06-20 18:24:23Z

0

In addition to what the other 2 have said, your evaluation code should be within the function, otherwise it is NOT going to be called every time the button is clicked, which I think is what you are after.

var ajout = 0;
function clickit()
{
 ajout++;  
 if (ajout==5)
   alert("TEST");   
}

answered Jun 20, 2012 at 18:24

Ben A. Hilleli

6061 gold badge7 silver badges21 bronze badges

Collectives™ on Stack Overflow

Basic Javascript issue (adding value)

6 Answers 6

2 Comments

1 Comment

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

1 Comment

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related