Ruby - Rails - Pass text to javascript

Question

Why isn't this passing text to javascript/jquery.? @i[:error] definitely has a string in it, I can print that on console.

js.erb file -

<% if @i[:error] != "" %>
<% puts "--> " + @i[:error]  %>
#--> error
#Validation error(s):
#-  Item Is not defined or blank. # that's the error string in @i[:error]

$(function() {
$("#error_message").attr("class", "message_error");
$('#error').text("<%= @i[:error]%>"); #Not working for @i[:error]
#$('#error').text("<%= "#{@i[:error]}"%>");#Not working for @i[:error]

#$('#error').text("Test"); #This is working
#$('#error').text("<%= "?????"%>"); #This is working
});
<% else %>
........#fine here
<% end %>

Mischa · Accepted Answer · 2012-05-13 13:28:09Z

2

Yes, it's probably because of the line break. You can fix it by using escape_javascript.

Escapes carriage returns and single and double quotes for JavaScript segments.

So:

$('#error').text("<%= escape_javascript(@i[:error]) %>");

answered May 13, 2012 at 13:28

Mischa

43.4k9 gold badges101 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Majoris Over a year ago

Yep, that is what it was. line break was causing the issue. You solved it.

makaroni4 · Accepted Answer · 2012-05-13 12:44:56Z

0

If you specify what debugger says it would be easier to understand the problem. This code for erb views works fine:

<% @i = {} %>
<% @i[:error] = "Error" %>  

<% unless @i[:error].blank? %>
  <script>
    $(document).ready(function() {
      $('#error').text('<%= @i[:error] %>'); // Works fine
    });
  </script>
<% end %>

Pay attention that emptiness of string is checked by blank? method, I think it look much nicer than using != operator.

answered May 13, 2012 at 12:44

makaroni4

2,2811 gold badge18 silver badges26 bronze badges

2 Comments

Majoris Over a year ago

Don't know what is wrong there. I tried your change but no luck.

Majoris Over a year ago

Can this be because of line break in the string that javascript cannot accept?

Collectives™ on Stack Overflow

Ruby - Rails - Pass text to javascript

2 Answers 2

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related