Pointer to a Pointer to a Structure and malloc memory for array

Question

I'm creating a pointer to a pointer to a structure to create a dynamic array with malloc in C, but I get a segmentation fault calling the struct array. Here is a quick rundown of my code:

#include <stdio.h>

typedef struct {
    int test1;
    int test2;
    }testStruct;

int main() {
    testStruct **neato;

    neato = (testStruct **) malloc( sizeof(testStruct *) * 5);
    // Array of 5 for convience

    // any neato[x]->testy call results in segmentation fault.
    scanf("%d", &neato[0]->test1);    // Segmentation fault

    return 0;
    }

I tried other calls like (*neato)[0].test1 and all result in segmentation fault. This is obviously not the proper way to do this or my GNU compiler is seriously outdated.

Do not cast the return value of malloc. See: c-faq.com/malloc/mallocnocast.html — Matt Eckert
– Matt Eckert, Commented Apr 5, 2012 at 2:44

Ed Swangren · Accepted Answer · 2012-04-05 04:39:42Z

5

You've allocated enough memory for 5 pointers. You have not however initialized the pointers, so they are garbage. Allocate the pointers and then proceed to initialize each pointer.

int elems = 5;

neato = malloc(sizeof(testStruct *) * elems);
for( i = 0; i < elems; ++i ) {
    neato[i] = malloc(sizeof(testStruct));
}

On a side note, I don't see a need for an array of pointers here. Why not simply allocate enough space for 5 testStructs (i.e., neato becomes a testStruct*) and pass the address of that pointer to the function that initializes it?

edited Apr 5, 2012 at 4:39

answered Apr 5, 2012 at 2:40

Ed Swangren

125k24 gold badges189 silver badges271 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

T.Jones Over a year ago

D'oh! Went straight over my head. Thanks for your help.

twain249 · Accepted Answer · 2012-04-05 02:41:40Z

0

you aren't mallocing space for all the structures themselves you have to add

for(int i = 0; i < 5; i++) {
    neato[i] = malloc(sizeof(testStruct));
}

After you malloc neato. Also you should check your return value from malloc for NULL to make sure malloc passed.

answered Apr 5, 2012 at 2:41

twain249

5,6861 gold badge23 silver badges26 bronze badges

3 Comments

Ed Swangren Over a year ago

No need to cast the result of malloc in C.

twain249 Over a year ago

@EdS. True but it doesn't hurt.

Ed Swangren Over a year ago

It can actually. It's just totally unnecessary, serving only to add verbosity to your code, and it can actually be bad in a more meaningful way. See: stackoverflow.com/questions/605845/…

asaelr · Accepted Answer · 2012-04-05 02:42:42Z

0

You allocated array of pointers, but did not assign valid address to these pointers.

If you only want to create dynamic array, use just pointer to the struct:

testStruct *neato;
neato = malloc( sizeof(testStruct) * 5);
scanf("%d", &neato[0].test1);

answered Apr 5, 2012 at 2:42

asaelr

5,4581 gold badge19 silver badges22 bronze badges

Collectives™ on Stack Overflow

Pointer to a Pointer to a Structure and malloc memory for array

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related